fix(webserver): remove stale onLoad tree calls in stats_tree.php - #111
Merged
Conversation
The body onLoad ran showBranch('br_Stats') and swapFolder('fl_Stats'),
written in 2008 when the stats tree had a single root node named
"Stats". The daemon has emitted multiple top-level branches (Transfer,
Connection, Clients, Servers, Shared Files) ever since, so
document.getElementById('br_Stats') is null and the handler threw an
uncaught TypeError on every page load without doing anything.
Remove the onLoad. The rendered state is unchanged (all branches start
expanded, which is what the broken handler already produced) and the
per-branch click-to-toggle handlers keep working; verified in headless
Chromium that the statistics page now loads with a clean console and
that collapsing/expanding a branch still works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The body onLoad ran showBranch('br_Stats') and swapFolder('fl_Stats'), written in 2008 when the stats tree had a single root node named "Stats". The daemon has emitted multiple top-level branches (Transfer, Connection, Clients, Servers, Shared Files) ever since, so document.getElementById('br_Stats') is null and the handler threw an uncaught TypeError on every page load without doing anything.
Remove the onLoad. The rendered state is unchanged (all branches start expanded, which is what the broken handler already produced) and the per-branch click-to-toggle handlers keep working; verified in headless Chromium that the statistics page now loads with a clean console and that collapsing/expanding a branch still works.