fix(webserver): free for() header expression lists in embedded PHP interpreter - #109
Merged
Merged
Conversation
…terpreter The three clauses of a for() header are comma-separated expression lists (PHP_OP_LIST chains). php_exp_tree_free() had no PHP_OP_LIST case, so list nodes fell through to the default branch, which frees tree_node.left/right but never the exp_node payloads — leaking every init/cond/step subtree once per parsed for() loop (echo and switch avoided this by walking their lists inline). Add a PHP_OP_LIST case that walks the ->next chain and frees both the payloads and the list spine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The three clauses of a for() header are comma-separated expression lists (PHP_OP_LIST chains). php_exp_tree_free() had no PHP_OP_LIST case, so list nodes fell through to the default branch, which frees tree_node.left/right but never the exp_node payloads — leaking every init/cond/step subtree once per parsed for() loop (echo and switch avoided this by walking their lists inline). Add a PHP_OP_LIST case that walks the ->next chain and frees both the payloads and the list spine.