fix(webserver): free array values when casting in embedded PHP interpreter - #108
Merged
Conversation
…reter cast_value_str() deleted the PHP_ARRAY_TYPE container but leaked the element var nodes it pointed to, and cast_value_dnum()/cast_value_fnum() dropped an array value without freeing anything. Passing an array to any native builtin (e.g. strlen($arr)) deep-copies it into the call scope and then casts the parameter, leaking that copy. Factor the correct array teardown out of value_value_free() into a shared free_array_value() helper and use it in all three cast functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cast_value_str() deleted the PHP_ARRAY_TYPE container but leaked the element var nodes it pointed to, and cast_value_dnum()/cast_value_fnum() dropped an array value without freeing anything. Passing an array to any native builtin (e.g. strlen($arr)) deep-copies it into the call scope and then casts the parameter, leaking that copy.
Factor the correct array teardown out of value_value_free() into a shared free_array_value() helper and use it in all three cast functions.