Quick follow-up on the above: switching servers within an active connection didn't go through the disconnect transition #163 was watching (the ed2k connected bit stays set), and the dialog-side EC_OP_CLEAR_SERVERINFO from amulegui ended up racing the new server's welcome message and silently wiping it. Fixed properly in #164 (now merged):

amuled's CamuleApp::ShowConnectionState now also tracks the connected-server pointer and clears server_msg on either disconnect OR A → B switch — before any of B's messages can land.
The GUI side just resets the text ctrl on the same transition; no more EC clear from the dialog.

Both amuled and amulegui need to be on the new build for the full fix. Mismatched versions still work, just not optimally:

New amulegui + old amuled: amuled won't auto-clear, but CServerInfoHandlerRem::HandlePacket's prefix-matching in the GUI handles the transition gracefully — UI clears on the switch via the dialog's ResetLog, subsequent polls only show the delta past m_seenSoFar, so new messages from B display correctly even with stale content sitting in amuled's buffer.
Old amulegui + new amuled: amuled clears server_msg correctly; old amulegui's HandlePacket sees the shortened buffer on the next poll and resets locally via its else-branch.

So upgrading one side first is safe — you just don't get the instant clear (and the race-free guarantee) until both are updated.

Uh oh!

small issue with PR#120 #162

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions