🐛 Update preconnects in amp-youtube component #39903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwinmombay
approved these changes
Mar 15, 2024
Member
|
thanks @westonruter |
Member
|
re-running jobs so we can merge |
Member
|
@westonruter do you mind rebasing and re-pushing, ill try and get the tests green but i can seem to retrigger the bundle size to get it to pass |
westonruter
force-pushed
the
update/amp-youtube-preconnects
branch
from
db0b27f to
79d88b3
Compare
Member
Author
|
@erwinmombay done, although I've also updated it to just remove the preconnect for fonts.gstatic.com. I found that no assets from that domain are loaded at all when emulating a mobile device. Fonts are only loaded on desktop. Since most AMP pages are served to mobile, it's probably best to just omit the fonts preconnect. |
Member
|
@westonruter merged |
TribooAnalytics
pushed a commit
to TribooAnalytics/amphtml
that referenced
this pull request
Apr 3, 2024
* Update preconnects in amp-youtube component * Remove preconnect to Google Fonts since not on mobile
eszponder
pushed a commit
to krzysztofequativ/amphtml
that referenced
this pull request
Apr 22, 2024
* Update preconnects in amp-youtube component * Remove preconnect to Google Fonts since not on mobile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just analyzed the resources which are loaded in a YouTube embed and they include:
fonts.gstatic.com(for the fonts used in the title)yt3.ggpht.com(for the channel logo)i.ytimg.com(for the poster image)www.youtube.com(for JS and CSS assets)www.gstatic.com(for more JS assets)Notably,
s.ytimg.comis not among the domains that resources are loaded from, although it is still being preconnected to:amphtml/extensions/amp-youtube/0.1/amp-youtube.js
Lines 117 to 121 in dccbba6
I suggest removing this preconnect and instead replace it with a preconnect to
fonts.gstatic.comsince it is used to render the title text which is the actual LCP element (since the poster background image is excluded based on the current LCP heuristics).