Skip to content

🐛 [Connatix Player] - Fix player not unmuting while docking #39792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
erwinmombay merged 3 commits into from
Feb 2, 2024
Merged

🐛 [Connatix Player] - Fix player not unmuting while docking #39792

erwinmombay merged 3 commits into from
Feb 2, 2024

Conversation

@cristisilav
Copy link
Contributor

@cristisilav cristisilav commented Feb 1, 2024

The current PR fixes two issues:

  1. Player could not be muted/unmuted through docking UI controls if user hadn't interacted with the player while it was embedded. This was solved by using the addUnsafeAllowAutoplay method.
  2. Desyncing between the player volume and the docking UI mute/unmute button icon. This was solved by only updating mute/unmute status after the volumeChanged command has been received.

@amp-owners-bot amp-owners-bot bot requested a review from nainar February 1, 2024 14:27
@amp-owners-bot
Copy link

amp-owners-bot bot commented Feb 1, 2024

Hey @alanorozco! These files were changed:

extensions/amp-connatix-player/0.1/amp-connatix-player.js

@erwinmombay erwinmombay requested review from erwinmombay and powerivq and removed request for nainar February 1, 2024 20:59
@erwinmombay
Copy link
Member

erwinmombay commented Feb 1, 2024

@powerivq can you help review when you get a chance. i'll take a look as well

@erwinmombay erwinmombay merged commit 4fdf6a7 into ampproject:main Feb 2, 2024
@swissspidy swissspidy mentioned this pull request Feb 15, 2024
Merged
2 tasks
eszponder pushed a commit to krzysztofequativ/amphtml that referenced this pull request Apr 22, 2024
@cristisilav @eszponder
🐛 [Connatix Player] - Fix player not unmuting while docking (ampproje…
82d2b53 
…ct#39792)

* fix player not being able to unmute while docking

* volume fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erwinmombay erwinmombay erwinmombay approved these changes

@powerivq powerivq powerivq approved these changes

Assignees

No one assigned

Labels

PR use: In Beta / Experimental PR use: In LTS PR use: In Stable

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cristisilav @erwinmombay @powerivq @ampprojectbot