🐛 [amp-story-audio-sticker] make grid layer mandatory ancestor, not parent #39727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @ampproject/wg-caching! These files were changed: |
Contributor
Author
|
/cc @ychsieh |
7 tasks
erwinmombay
requested review from
banaag and
erwinmombay
and removed request for
dmanek
Member
|
@banaag could you help review tihs one |
Member
|
@swissspidy sorry. @ychsieh is currently OOO until next week and I'd like for them to make the final approval |
ychsieh
approved these changes
Jan 12, 2024
Contributor
ychsieh
left a comment
ychsieh
left a comment
There was a problem hiding this comment.
Agree that we should allow wrappers in between. Thanks for the change Pascal!
Contributor
Author
|
@erwinmombay @ychsieh can we merge this? |
erwinmombay
approved these changes
Jan 30, 2024
2 tasks
erwinmombay
added a commit
to erwinmombay/amphtml
that referenced
this pull request
Mar 7, 2024
…rge conflicts, if any.
erwinmombay
added a commit
to erwinmombay/amphtml
that referenced
this pull request
Mar 7, 2024
…rge conflicts, if any.
eszponder
pushed a commit
to krzysztofequativ/amphtml
that referenced
this pull request
Apr 22, 2024
…arent (ampproject#39727) * [amp-story-audio-sticker] make grid layer mandatory ancestor, not parent * Update out file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracting my question at #39184 (comment) into a PR for more visibility.
Just like
<amp-story-shopping-tag>, I don't see why this element shouldn't be allowed to have some wrapper elements. This change would make implementation in Google's WordPress Web Stories plugin more straightforward, where we use absolute positioning for elements.