Pre-throttle error reports from Stable client#28181
Merged
rcebulko merged 3 commits intoampproject:masterfrom May 4, 2020
Merged
Pre-throttle error reports from Stable client#28181rcebulko merged 3 commits intoampproject:masterfrom
rcebulko merged 3 commits intoampproject:masterfrom
Conversation
jridgewell
reviewed
May 4, 2020
|
|
||
| // TODO(https://github.com/ampproject/error-tracker/issues/129): Remove once | ||
| // all clients are serving a version with pre-throttling. | ||
| if (data['rt'] === 'production') { |
Contributor
There was a problem hiding this comment.
I don't think we can ever remove this, since we don't wan the reporting function to throttle canary.
Contributor
Author
There was a problem hiding this comment.
As in, we can remove the "prethrottle" param and just use data['rt'] directly in the conditional above. We only need to explicitly provide "prethrottle" while some versions aren't doing it.
jridgewell
approved these changes
May 4, 2020
ldoroshe
pushed a commit
to ldoroshe/amphtml
that referenced
this pull request
May 8, 2020
* Pre-throttle error reports from Stable client * Use runtime field instead of RTV * Shorten throttled --> pt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of ampproject/error-tracker#129
Must not reach stable before the accompanying change in the error-tracker repo.