Skip to content

🏗📖 Auto-format all markdown files in ampproject/amphtml with Prettier #25182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rsimha merged 7 commits into from
Oct 24, 2019
Merged

🏗📖 Auto-format all markdown files in ampproject/amphtml with Prettier #25182

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2675875
Check markdown files during `gulp prettify`
rsimha Oct 18, 2019
5d947ed
Skip broken link check when a PR edits >20 markdown files
rsimha Oct 24, 2019
53388a1
Print suggested fixes if formatting errors are detected
rsimha Oct 24, 2019
85afc0a
Exempt github issue templates from markdown format check
rsimha Oct 23, 2019
68bbc0d
Auto-fix markdown files with prettier
rsimha Oct 24, 2019
d89ad10
Make extension generator resilient to markdown file auto-fixing
rsimha Oct 24, 2019
09bb666
Self review + fixes
rsimha Oct 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Self review + fixes
  • Loading branch information
@rsimha
rsimha committed Oct 24, 2019
commit 09bb6662d3edd4ceb39e035f1ecd33aac55bc968
14 changes: 7 additions & 7 deletions contributing/building-an-amp-extension.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,17 +400,17 @@ the element will never be preloaded or laid out. This is true to all
nested amp-elements that are not placeholders. AMP runtime will schedule
nested amp-elements that are placeholders.

<!-- prettier-ignore-start -->
```html
<amp-carousel>
← Parent element
<amp-figure>
← Parent needs to schedule this element <amp-img placeholder></amp-img> ←
AMP will schedule this when amp-figure is scheduled <amp-img></amp-img> ←
Parent needs to schedule this element <amp-fit-text></amp-fit-text> ← Parent
needs to schedule this element
<amp-carousel> ← Parent element
<amp-figure> ← Parent needs to schedule this element
<amp-img placeholder></amp-img> ← AMP will schedule this when amp-figure is scheduled
<amp-img></amp-img> ← Parent needs to schedule this element
<amp-fit-text></amp-fit-text> ← Parent needs to schedule this element
</amp-figure>
</amp-carousel>
```
<!-- prettier-ignore-end -->

## Allowing proper validations

Expand Down
2 changes: 1 addition & 1 deletion contributing/component-validator-rules.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ tags: { # amp-cat extended component
This tells the validator that we want to define a new tag. In this case, we want
to validate a tag that looks something like the following:

> `<script async custom-element='amp-cat'` > `src='https://cdn.ampproject.org/v0/amp-cat-0.1.js'></script>`
> `<script async custom-element='amp-cat' src='https://cdn.ampproject.org/v0/amp-cat-0.1.js'></script>`

```
html_format: AMP
Expand Down
4 changes: 3 additions & 1 deletion contributing/release-schedule.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@

- [Detailed schedule](#detailed-schedule)
- [Determining if your change is in production](#determining-if-your-change-is-in-production)
- [Cherry picks](#cherry-picks) - [Cherry pick criteria](#cherry-pick-criteria) - [Process for requesting a cherry pick](#process-for-requesting-a-cherry-pick)
- [Cherry picks](#cherry-picks)
- [Cherry pick criteria](#cherry-pick-criteria)
- [Process for requesting a cherry pick](#process-for-requesting-a-cherry-pick)
- [AMP Dev Channel](#amp-dev-channel)
- [AMP Release Candidate (RC) Channel](#amp-release-candidate-rc-channel)
- [Release cadence](#release-cadence)
Expand Down