Adds selectPlatform method for amp-subscriptions #13682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvoytenko
suggested changes
Feb 27, 2018
| @@ -83,7 +83,7 @@ export class EntitlementStore { | |||
| } | |||
| } | |||
|
|
|||
| if (entitlementsResolved === this.serviceIds_.length) { | |||
| if (this.areAllPlatformsResolved_()) { | |||
There was a problem hiding this comment.
That means this promise may never resolve if it wasn't resolved yet. You need to check areAllplatformsResolved_ in the onChange below as well. That should be covered by a test as well.
| */ | ||
| selectPlatform() { | ||
| return this.getAllPlatformsEntitlements_().then(entitlements => { | ||
| return this.selectApplicablePlatform_(entitlements); |
There was a problem hiding this comment.
Add a TODO to explain that in the future we may be able to resolve a selected platform faster than waiting for all platforms. E.g. a first "subscriber" platform can be selected right away.
dvoytenko
approved these changes
Feb 28, 2018
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
* fix animating circle fixed position * adding selectPlatform method * fixing comments * fixing types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
selectPlatformmethod in entitlements storeallEntitlementsResolvedpromise