Skip to content

Fix form-label lint errors #7823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thelovekesh merged 1 commit into from
Jun 25, 2024
Merged

Fix form-label lint errors #7823

thelovekesh merged 1 commit into from
Jun 25, 2024

Conversation

@thelovekesh
Copy link
Collaborator

@thelovekesh thelovekesh commented Jun 25, 2024 •
edited
Loading

Summary

Fix the following ESLint errors:

➜  amp git:(fix/eslint-errors) npm run lint:js

> lint:js
> wp-scripts lint-js


/home/thelovekesh/Desktop/work/google/wpdev/public/content/plugins/amp/assets/src/onboarding-wizard/pages/technical-background/index.js
  64:6  error  A form label must be associated with a control  jsx-a11y/label-has-associated-control
  97:6  error  A form label must be associated with a control  jsx-a11y/label-has-associated-control

✖ 2 problems (2 errors, 0 warnings)

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@thelovekesh thelovekesh requested a review from westonruter June 25, 2024 14:46
@github-actions
Copy link
Contributor

github-actions bot commented Jun 25, 2024

Plugin builds for 479db32 are ready 🛎️!

Checksums 
# Development build checksums
a63ad70debb226514d34f5d83d99ec6714536a3527574443d3983526e7197b14 *amp.zip

# Production build checksums
397397614101719da33610248747d9f7abeeb1924e57beabe524d617a636cd61 *amp.zip

Warning

These builds are for testing purposes only and should not be used in production.

@westonruter westonruter added this to the v2.5.4 milestone Jun 25, 2024
@thelovekesh thelovekesh merged commit 8c1e614 into develop Jun 25, 2024
@thelovekesh thelovekesh deleted the fix/eslint-errors branch June 25, 2024 15:45
@thelovekesh
Copy link
Collaborator Author

thelovekesh commented Jul 14, 2024

There are no ESLint errors on the develop branch. QA Passed ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@westonruter westonruter westonruter approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Ongoing
Archived in project

Milestone

v2.5.4

Development

Successfully merging this pull request may close these issues.

3 participants

@thelovekesh @westonruter