Skip to content

Use posts member of WP_Query instead of get_posts method #7782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
westonruter merged 2 commits into from
Jul 8, 2024
Merged

Use posts member of WP_Query instead of get_posts method #7782

westonruter merged 2 commits into from
Jul 8, 2024

Conversation

@westonruter
Copy link
Member

@westonruter westonruter commented Apr 30, 2024 •
edited
Loading

Summary

Fixes #7781

This is just a simple search-and-replace. Changes are not tested.

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@westonruter westonruter added this to the v2.5.4 milestone Apr 30, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Apr 30, 2024 •
edited
Loading

Plugin builds for 3e75a33 are ready 🛎️!

Checksums 
# Development build checksums
25c05c15fd06637dbd95a474e9010293ba3522c6d551c441686dea1350bbca8f *amp.zip

# Production build checksums
e2d26d0d085af4b0f141e340330e124e21357579df36827a4c253918ace86931 *amp.zip

Warning

These builds are for testing purposes only and should not be used in production.

@westonruter westonruter mentioned this pull request Apr 30, 2024
Closed
@westonruter westonruter requested a review from thelovekesh April 30, 2024 16:25
@thelovekesh thelovekesh force-pushed the fix/query-get-posts branch from bb7e4fd to 9961198 Compare July 7, 2024 08:30
thelovekesh
thelovekesh reviewed Jul 7, 2024
View reviewed changes
tests/php/test-amp-style-sanitizer.php
Comment on lines +3521 to +3525
if ( defined( 'GUTENBERG_VERSION' ) && version_compare( GUTENBERG_VERSION, '18.7', '>=' ) ) {
$this->assertStringContainsString( '.wp-block-audio :where(figcaption)', $amphtml_source, 'Expected block-library/style.css' );
} else {
$this->assertStringContainsString( '.wp-block-audio figcaption', $amphtml_source, 'Expected block-library/style.css' );
}
Copy link
Collaborator

@thelovekesh thelovekesh Jul 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See WordPress/gutenberg#62689

thelovekesh
thelovekesh reviewed Jul 7, 2024
View reviewed changes
tests/php/test-amp-style-sanitizer.php
Comment on lines +3527 to +3531
if ( version_compare( strtok( get_bloginfo( 'version' ), '-' ), '6.6', '>=' ) ) {
$this->assertStringContainsString( '[class^="wp-block-"]:not(.wp-block-gallery) > figcaption', $amphtml_source, 'Expected twentyten/blocks.css' );
} else {
$this->assertStringContainsString( '[class^="wp-block-"]:not(.wp-block-gallery) figcaption', $amphtml_source, 'Expected twentyten/blocks.css' );
}
Copy link
Collaborator

@thelovekesh thelovekesh Jul 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See WordPress/wordpress-develop@a285228

@thelovekesh
Copy link
Collaborator

thelovekesh commented Jul 7, 2024

Using ( new WP_Query( $args ) )->posts is widely adopted and I have observed its usage in various projects. Some examples from repos of rtCamp, Automattic, and Google: https://github.com/search?q=org%3ArtCamp+OR+org%3AAutomattic+OR+org%3AGoogle++%22%24query-%3Eposts%22+&type=code

@thelovekesh
Copy link
Collaborator

thelovekesh commented Jul 7, 2024

@westonruter We are good to merge this. Can you please take a look at the test files I have changed?

@westonruter westonruter merged commit 3175da6 into develop Jul 8, 2024
@westonruter westonruter deleted the fix/query-get-posts branch July 8, 2024 16:50
@thelovekesh
Copy link
Collaborator

thelovekesh commented Jul 14, 2024

QA Passed ✅

Tested support data module to test if accessing the $posts property is working as expected. Posts are being fetched as expected.

(Note the URL included in Validated URLs)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thelovekesh thelovekesh thelovekesh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.5.4

Development

Successfully merging this pull request may close these issues.

Incorrect use of $query->get_posts(), resulting in double request processing

3 participants

@westonruter @thelovekesh