Skip to content

Bump ampproject/amp-toolbox; Fix Gutenberg's validation issues with Script Modules #7736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
westonruter merged 4 commits into from
Feb 7, 2024
Merged

Bump ampproject/amp-toolbox; Fix Gutenberg's validation issues with Script Modules #7736

westonruter merged 4 commits into from
Feb 7, 2024

Conversation

@thelovekesh
Copy link
Collaborator

@thelovekesh thelovekesh commented Feb 5, 2024 •
edited
Loading

Summary

Fixes #7737

Bump ampproject/amp-toolbox from 0.11.4 to 0.11.5. See https://github.com/ampproject/amp-toolbox-php/releases/tag/0.11.5

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2024 •
edited
Loading

Plugin builds for 3bafe7b are ready 🛎️!

Checksums 
# Development build checksums
7976903cf8c76ae8a9a5b2099d15f7932bb7d217346f1f315ee718a77249b04e *amp.zip

# Production build checksums
fcad78d9ddcf0451ae1783c423f66d0c3caffe4b788cdd9bbd094e890705c2fc *amp.zip

Warning

These builds are for testing purposes only and should not be used in production.

@westonruter westonruter added this to the v2.5.3 milestone Feb 5, 2024
@westonruter
Copy link
Member

westonruter commented Feb 7, 2024

Looks like there's another Gutenberg update that is breaking the tests.

@westonruter
Copy link
Member

westonruter commented Feb 7, 2024

Fixed compatibility with 6.5-alpha which introduced script modules.

@westonruter
Copy link
Member

westonruter commented Feb 7, 2024

E2E tests are failing still, but that's also happening when just updating dev dependencies.

@westonruter westonruter merged commit b5eb42c into develop Feb 7, 2024
@westonruter westonruter deleted the bump/amp-toolbox-to-0.11.5 branch February 7, 2024 19:08
@westonruter westonruter mentioned this pull request Feb 27, 2024
Closed
@thelovekesh thelovekesh changed the title Bump ampproject/amp-toolbox from 0.11.4 to 0.11.5 Bump ampproject/amp-toolbox from 0.11.4 to 0.11.5; Fix Gutenberg's validation issues with Script Modules Mar 20, 2024
@thelovekesh thelovekesh changed the title Bump ampproject/amp-toolbox from 0.11.4 to 0.11.5; Fix Gutenberg's validation issues with Script Modules Bump ampproject/amp-toolbox; Fix Gutenberg's validation issues with Script Modules Mar 20, 2024
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@westonruter westonruter westonruter approved these changes

@swissspidy swissspidy swissspidy approved these changes

Assignees

No one assigned

Labels

Changelogged Whether the issue/PR has been added to release notes.

Projects

None yet

Milestone

v2.5.3

Development

Successfully merging this pull request may close these issues.

Gutenberg's validation issues with Script Modules

4 participants

@thelovekesh @westonruter @swissspidy