Update amphtml spec to 2309011827000#7615
Conversation
| if satisfies in extension_specs_by_satisfies: | ||
| raise Exception( 'Duplicate extension script that satisfies %s.' % satisfies ) | ||
| # TODO: Confirm once if this need to be disabled as there can be more than once spec per extension. | ||
| # if satisfies in extension_specs_by_satisfies: | ||
| # raise Exception( 'Duplicate extension script that satisfies %s.' % satisfies ) |
There was a problem hiding this comment.
It looks like satisfies was renamed to satisfies_condition in the protoascii, so this update can be made above.
01cc0cc to
89e60a2
Compare
d33906a to
da942cf
Compare
- Remove assertions for bento specific amp scripts and styles.
- Move `amp_is_bento_enabled()` to deprecated.php - Mark `amp_bento_enabled` filter as deprecated
Co-authored-by: Weston Ruter <[email protected]>
Co-authored-by: Weston Ruter <[email protected]>
ca8cc7f to
1bbacbb
Compare
|
Plugin builds for 93ade31 are ready 🛎️!
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #7615 +/- ##
=============================================
- Coverage 78.49% 77.15% -1.34%
+ Complexity 6909 6897 -12
=============================================
Files 210 277 +67
Lines 22228 23356 +1128
=============================================
+ Hits 17447 18021 +574
- Misses 4781 5335 +554
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
I'm seeing some missing changes in PHP versus the diff in protoascii:
Could it be that the diff was gathered for a later release than the PHP was generated from? |
westonruter
left a comment
There was a problem hiding this comment.
Aside from the missing additions, this PR looks great! If fixing the omissions is just a matter of re-running with the current release, then we should do that. Otherwise, that could be done in another PR.
|
I forgot to mention it here but #7597 also attempted to update the spec previously, which has already covered the above missing changes. |
Previously #7078 and #7597
./bin/amphtml-update.sh(lando ssh -c 'bash ./bin/amphtml-update.sh vendor/amphtml').Changelog
amp-wordpress-embeddefault to1.0as bento only component available for this extension.satisfiesspec key withsatisfies_conditionin spec generator.amp-redbull-player.fetchpioritytoimgandlinkelements. See Update spec to include fetchpriority support #7601.amp-slikeplayercomponent.amp-story-audio-stickercomponent.descendant_tag_listforamp-mega-menuamphtml#38028. Fixes Skip rendering child amp-img tags of amp-mega-menu #7029Details
( PREV_VERSION=2204221712000; THIS_VERSION=2309011827000; git checkout $THIS_VERSION; git diff $PREV_VERSION...$THIS_VERSION -w -- build-system/compile/bundles.config.extensions.json $( git ls-files | grep '.protoascii' ); git checkout - > /dev/null )Diff 2204221712000...2309011827000