Skip to content

Update representation of empty strings on URL validation screen #7432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
westonruter merged 2 commits into from
Jan 31, 2023
Merged

Update representation of empty strings on URL validation screen #7432

westonruter merged 2 commits into from
Jan 31, 2023

Conversation

@thelovekesh
Copy link
Collaborator

@thelovekesh thelovekesh commented Jan 30, 2023 •
edited
Loading

Summary

Before:
image

After:
image

Fixes #5598

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@thelovekesh thelovekesh self-assigned this Jan 30, 2023
@thelovekesh thelovekesh added WS:UX Work stream for UX/Front-end Validation labels Jan 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2023 •
edited
Loading

Plugin builds for fdd22ef are ready 🛎️!

@westonruter westonruter added this to the v2.4 milestone Jan 30, 2023
westonruter
westonruter approved these changes Jan 30, 2023
View reviewed changes
@westonruter westonruter merged commit aca373c into develop Jan 31, 2023
@westonruter westonruter deleted the enhancement/better-empty-string-representation branch January 31, 2023 19:51
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@westonruter westonruter westonruter approved these changes

Assignees

@thelovekesh thelovekesh

Labels

Changelogged Whether the issue/PR has been added to release notes. Validation WS:UX Work stream for UX/Front-end

Projects

None yet

Milestone

v2.4

Development

Successfully merging this pull request may close these issues.

On URL validation screen, improve representation of empty strings

3 participants

@thelovekesh @westonruter