Add WP-CLI commands for managing AMP settings #7368
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thelovekesh
commented
Dec 6, 2022
thelovekesh
force-pushed
the
add/plugin-settings-wp-cli-command
branch
from
d9f50af to
fbfcb62
Compare
thelovekesh
force-pushed
the
add/plugin-settings-wp-cli-command
branch
from
f8e212b to
fbfcb62
Compare
westonruter
requested changes
Jan 24, 2023
src/Cli/OptionCommand.php
Outdated
| Option::READER_THEME, | ||
| Option::THEME_SUPPORT, | ||
| Option::MOBILE_REDIRECT, | ||
| Option::SUPPRESSED_PLUGINS, |
Member
There was a problem hiding this comment.
IMO we don't need to include Suppressed Plugins
Suggested change
| Option::SUPPRESSED_PLUGINS, |
src/Cli/OptionCommand.php
Outdated
Comment on lines
58
to
64
|
|
||
| /** | ||
| * PluginSuppression instance. | ||
| * | ||
| * @var PluginSuppression | ||
| */ | ||
| private $plugin_suppression; |
Member
There was a problem hiding this comment.
Suggested change
| /** | |
| * PluginSuppression instance. | |
| * | |
| * @var PluginSuppression | |
| */ | |
| private $plugin_suppression; |
src/Cli/OptionCommand.php
Outdated
Comment on lines
79
to
83
| * @param PluginSuppression $plugin_suppression PluginSuppression instance. | ||
| */ | ||
| public function __construct( ReaderThemes $reader_themes, PluginSuppression $plugin_suppression ) { | ||
| $this->reader_themes = $reader_themes; | ||
| $this->plugin_suppression = $plugin_suppression; |
Member
There was a problem hiding this comment.
Suggested change
| * @param PluginSuppression $plugin_suppression PluginSuppression instance. | |
| */ | |
| public function __construct( ReaderThemes $reader_themes, PluginSuppression $plugin_suppression ) { | |
| $this->reader_themes = $reader_themes; | |
| $this->plugin_suppression = $plugin_suppression; | |
| */ | |
| public function __construct( ReaderThemes $reader_themes ) { | |
| $this->reader_themes = $reader_themes; |
src/Cli/OptionCommand.php
Outdated
Comment on lines
162
to
163
| // Add reader themes to the options. | ||
| $options[ self::READER_THEMES ] = wp_list_pluck( $this->reader_themes->get_themes(), 'slug' ); |
Member
There was a problem hiding this comment.
This may be confusing to a user as this is not actually an option.
If we want a way to list the available Reader themes, this can be done via a separate command entirely. For example, wp amp options list-reader-themes.
thelovekesh
force-pushed
the
add/plugin-settings-wp-cli-command
branch
from
8cab1f3 to
bbc5c1c
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5783
Checklist