Add PHPUnit tests workflow for multisite #7321

thelovekesh · 2022-11-01T04:51:38Z

Summary

This PR also updates deprecated set-output commands in GitHub Actions workflow files. See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Checklist

My code is tested and passes existing tests.
My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

thelovekesh · 2022-11-01T12:49:28Z

@westonruter I have configured workflow for both testsuites i.e. default and external-http. Some tests seem to be failing mainly from helper functions. Should I fix them in the same PR? Can you please take a look if any test is need to be skipped?

westonruter · 2022-11-01T18:03:02Z

Interesting. Yes, they should be fixed in this PR. For each failure, I'd suggest checking to see what the cause of the failure is. It may be due to a regular admin user not having all the same privileges as a superadmin on multisite. Therefore the fix may be just to check if its multisite, and then grant the user being tested with superadmin privileges.

Some tests probably also should be skipped if the functionality specifically is not available in multisite. For example, installing themes from the onboarding wizard I don't think is available on multisite.

It'll be interesting to see if this uncovers actual bugs with the code and not just incomplete tests!

…vironment

Mock a new blog to create posts for AMP paired mode testing

thelovekesh · 2022-11-21T14:47:21Z

@westonruter I believe the capability here should be install_themes. Thoughts?

amp-wp/src/Admin/AfterActivationSiteScan.php

Line 214 in 650a4eb

if ( current_user_can( 'switch_themes' ) ) {

… in multisite env

…ultisite env

…er admin access in multisite env

…multisite env

…n multisite env

…sed_for_template_mode to have super admin access in multisite env

…te_reader_theme Update user privialge in multisite env and pass themes in wp_prepare_themes_for_js()

…B queries in multisite env

…files

codecov · 2022-11-23T07:52:15Z

Codecov Report

Merging #7321 (deb6e3c) into develop (9f6567c) will decrease coverage by 0.80%.
The diff coverage is n/a.

❗ Current head deb6e3c differs from pull request most recent head 17dd543. Consider uploading reports for the commit 17dd543 to get more accurate results

@@              Coverage Diff              @@
##             develop    #7321      +/-   ##
=============================================
- Coverage      78.60%   77.80%   -0.81%     
  Complexity      6852     6852              
=============================================
  Files            209      276      +67     
  Lines          18655    19814    +1159     
=============================================
+ Hits           14664    15416     +752     
- Misses          3991     4398     +407

Flag	Coverage Δ
javascript	`64.88% <ø> (?)`
php	`78.60% <ø> (ø)`
unit	`78.60% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
assets/src/components/conditional-details/index.js	`100.00% <0.00%> (ø)`
assets/src/common/helpers/index.js	`91.22% <0.00%> (ø)`
.../src/onboarding-wizard/components/stepper/index.js	`66.66% <0.00%> (ø)`
...s/amp-validation-status/revalidate-notification.js	`100.00% <0.00%> (ø)`
assets/src/block-editor/constants.js	`100.00% <0.00%> (ø)`
assets/src/components/amp-drawer/index.js	`73.07% <0.00%> (ø)`
assets/src/components/amp-admin-notice/index.js	`100.00% <0.00%> (ø)`
...sets/src/block-validation/components/icon/index.js	`100.00% <0.00%> (ø)`
assets/src/components/dev-tools-toggle/index.js	`80.00% <0.00%> (ø)`
...ts/src/common/helpers/test/fixtures/mockClasses.js	`100.00% <0.00%> (ø)`
... and 57 more

westonruter · 2022-11-23T19:53:53Z

I believe the capability here should be install_themes. Thoughts?

@thelovekesh yes, I think you're right. The page requires install_themes: https://github.com/WordPress/wordpress-develop/blob/04f55a430e2ee5a88e9b5b5485b75a68fabd5a83/src/wp-admin/theme-install.php#L15-L17

tests/php/src/Admin/UserRESTEndpointExtensionTest.php

tests/php/src/Helpers/MockAdminUser.php

Co-authored-by: Weston Ruter <[email protected]>

…l to mock super admin user in multisite

thelovekesh added 6 commits November 1, 2022 10:16

Add PHP version in wp-env config

903956c

Add workflow to run PHP unit tests on multisite

16b6c9e

Add npm script to run PHP unit tests on multisite

cdb9dca

Fix yml syntax error

f8572bd

Remove skip condition from multisite unit tests workflow for testing

d6a69d2

Use phpunit from vendor

e01869e

thelovekesh force-pushed the add/multisite-phpunit-workflow branch from 8f6424d to b8007c0 Compare November 1, 2022 05:22

Move tests with base dir as amp

8997b11

thelovekesh force-pushed the add/multisite-phpunit-workflow branch from b8007c0 to 8997b11 Compare November 1, 2022 06:22

thelovekesh added 2 commits November 1, 2022 11:59

Fix base dir path errors

533d940

Add matrix to run different testsuites

91cb0d1

thelovekesh force-pushed the add/multisite-phpunit-workflow branch from 0780fd4 to 15fa7dd Compare November 1, 2022 06:59

Fix yml syntax error

ac70da5

thelovekesh force-pushed the add/multisite-phpunit-workflow branch from 15fa7dd to ac70da5 Compare November 1, 2022 07:00

Merge branch 'develop' into add/multisite-phpunit-workflow

b84213d

thelovekesh force-pushed the add/multisite-phpunit-workflow branch from 5341d82 to b84213d Compare November 21, 2022 13:42

thelovekesh added 2 commits November 21, 2022 19:20

Update test_amp_get_content_sanitizers_with_dev_mode for multisite en…

6c1ef34

…vironment

Update test_amp_has_paired_endpoint_go_to for multisite environment

ce73a7c

Mock a new blog to create posts for AMP paired mode testing

thelovekesh added 9 commits November 21, 2022 20:19

Update test_get_amp_compatible_plugins_url to have super admin access…

182993d

… in multisite env

Update test cases in ReaderThemesTest to have super admin access in m…

1a6301c

…ultisite env

Update SiteHealthTest::test_register_async_test_endpoints to have sup…

e4fc60d

…er admin access in multisite env

Update SupportLinkTest::test_is_needed to have super admin access in …

9bddbeb

…multisite env

Update SupportScreenTest::test_is_needed to have super admin access i…

e195625

…n multisite env

Update UserRESTEndpointExtensionTest::test_update_review_panel_dismis…

c7fcac6

…sed_for_template_mode to have super admin access in multisite env

Update ReaderThemeLoaderTest::test_filter_wp_prepare_themes_to_indica…

18d3c7b

…te_reader_theme Update user privialge in multisite env and pass themes in wp_prepare_themes_for_js()

Update Test_Uninstall::test_remove_plugin_data to calculate correct D…

2f8c7a7

…B queries in multisite env

Remove vague variable decleration

69649ae

thelovekesh force-pushed the add/multisite-phpunit-workflow branch from 4748f1f to 4dc01a4 Compare November 23, 2022 04:44

thelovekesh added 4 commits November 23, 2022 10:14

Merge branch 'develop' into add/multisite-phpunit-workflow

6b4d87f

Remove comment from job condition

83b5304

Add steps to update PHPUnit version

c533fc1

Revert quote_type to single

88fb246

thelovekesh force-pushed the add/multisite-phpunit-workflow branch from 5c956d8 to 88fb246 Compare November 23, 2022 07:02

thelovekesh requested a review from westonruter November 23, 2022 07:05

Update deprecated set-output commands with GITHUB_OUTPUT environment …

deb6e3c

…files

thelovekesh force-pushed the add/multisite-phpunit-workflow branch from 5e64f53 to deb6e3c Compare November 23, 2022 07:47

thelovekesh force-pushed the add/multisite-phpunit-workflow branch from 17dd543 to deb6e3c Compare November 23, 2022 14:12

westonruter reviewed Nov 23, 2022

View reviewed changes

tests/php/src/Admin/UserRESTEndpointExtensionTest.php Show resolved Hide resolved

thelovekesh added 3 commits November 24, 2022 10:19

Add inline comment for switching blogs in multisite tests

ad687db

Update mock_admin_user() to return WP_User object

56cb572

Update mocking admin user with mock_admin_user()

74771af

westonruter reviewed Nov 24, 2022

View reviewed changes

tests/php/src/Helpers/MockAdminUser.php Outdated Show resolved Hide resolved

thelovekesh and others added 3 commits November 24, 2022 10:41

Fix duplicate WP user creation

e41fa2c

Co-authored-by: Weston Ruter <[email protected]>

Update current user capability to install_themes

2417d5b

Update AfterActivationSiteScanTest::test_get_amp_compatible_themes_ur…

8f51deb

…l to mock super admin user in multisite

thelovekesh requested a review from westonruter November 24, 2022 05:27

westonruter approved these changes Nov 24, 2022

View reviewed changes

westonruter merged commit 8c8564e into develop Nov 24, 2022

westonruter deleted the add/multisite-phpunit-workflow branch November 24, 2022 05:33

westonruter added this to the v2.3.1 milestone Nov 24, 2022

westonruter modified the milestones: v2.3.1, v2.4 Jan 26, 2023

westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Feb 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add PHPUnit tests workflow for multisite #7321

Add PHPUnit tests workflow for multisite #7321

Uh oh!

thelovekesh commented Nov 1, 2022 •

edited

Loading

Uh oh!

thelovekesh commented Nov 1, 2022

Uh oh!

westonruter commented Nov 1, 2022

Uh oh!

thelovekesh commented Nov 21, 2022

Uh oh!

codecov bot commented Nov 23, 2022 •

edited

Loading

Uh oh!

westonruter commented Nov 23, 2022

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add PHPUnit tests workflow for multisite #7321

Add PHPUnit tests workflow for multisite #7321

Uh oh!

Conversation

thelovekesh commented Nov 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

thelovekesh commented Nov 1, 2022

Uh oh!

westonruter commented Nov 1, 2022

Uh oh!

thelovekesh commented Nov 21, 2022

Uh oh!

codecov bot commented Nov 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

westonruter commented Nov 23, 2022

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

thelovekesh commented Nov 1, 2022 •

edited

Loading

codecov bot commented Nov 23, 2022 •

edited

Loading