Skip to content

Downgrade PHP version from 8.0 to 5.6 for development builds #7030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
westonruter merged 1 commit into from
Apr 6, 2022
Merged

Downgrade PHP version from 8.0 to 5.6 for development builds #7030

westonruter merged 1 commit into from
Apr 6, 2022

Conversation

@westonruter
Copy link
Member

@westonruter westonruter commented Apr 6, 2022

@westonruter westonruter added this to the v2.2.3 milestone Apr 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2022

Plugin builds for e880012 are ready 🛎️!

@westonruter westonruter merged commit f478713 into develop Apr 6, 2022
@westonruter westonruter deleted the update/build-php-version branch April 6, 2022 18:17
westonruter added a commit that referenced this pull request Apr 6, 2022
@westonruter
Downgrade PHP version from 8.0 to 5.6 for development builds (#7030)
3d56a3b
@westonruter
Copy link
Member Author

westonruter commented Apr 6, 2022

To prevent the support topic issue from coming up again:

  1. We should run phpcs PHP version compatibility checks on all files in the vendor directory, or:
  2. Use the build ZIP from GHA instead of the version built locally and also ensure that the version of PHP used for building always matches the minimum version supported.

@westonruter westonruter mentioned this pull request Apr 6, 2022
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.2.3

Development

Successfully merging this pull request may close these issues.

2 participants

@westonruter