Convert 100% width Facebook widgets to fixed-height layout #2776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
approved these changes
Jul 10, 2019
westonruter
added a commit
that referenced
this pull request
Jul 11, 2019
…-block-size-validation * 'develop' of github.com:ampproject/amp-wp: (104 commits) Update Miina's WordPress.org username Short-circuit the filter for users with necessary caps. Fix conversion of CSS selectors when HTML tag maps to multiple… (#2793) Add necessary tags for background media. Style fixes for upstream updates (#2778) Update dependency lodash to v4.17.14 (#2780) Add opacity to expected results of tests, too. Add opacity to allowed attributes, too. Whitelist data-temp-style-hash for all tags. Improve filters. Convert 100% width Facebook widgets to fixed-height layout (#2776) Update dependency @babel/plugin-proposal-object-rest-spread to… (#2774) Update dependency lodash to v4.17.13 (#2775) Update dependency @babel/core to v7.5.4 (#2773) Update dependency @babel/plugin-proposal-object-rest-spread to v7.5.3 (#2772) Update dependency postcss-preset-env to v6.7.0 (#2770) Remove redundant SKIP_ECHO_PATHS_SCOPE=1 since CHECK_SCOPE=all Update dependency @babel/plugin-proposal-object-rest-spread to… (#2768) Properly enforce short array syntax using phpcbf Enforce short array syntax via PHPCS ...
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue identified in the AMP plugin forum: https://wordpress.org/support/topic/amp-error-on-facebook-widget-width/
Given input such as:
The AMP plugin is currently converting this into:
This is an error because AMP does not allow percentage widths. So this PR causes the embed to be output instead as:
This was done elsewhere in #2712. Also related to #2146.
Build for testing: amp.zip (v1.2.1-alpha-20190710T044256Z-4a34c951)