Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

I signed it!

CLAs look good, thanks!

This is interesting. I'm very novice with Docker, but we've recently using https://github.com/felixarntz/wordpressdev as the environment to do development on, at least a few of us. It's also based on Docker, though it doesn't require putting Docker configuration in the repo as it just uses whatever environment it finds itself in. I know that Gutenberg has a Docker setup, but I haven't used it. I'm not very good to review this.

/cc @felixarntz

I would generally advise against putting a dev environment into a specific project's repository. IMO this plugin should provide the tools needed to develop for it (via NPM and Composer), but it should be agnostic about which dev environment to use.

If there is consensus that a specific dev environment for the AMP plugin makes sense, it should be a separate repository, that could be linked to from the readme for example.

Thanks for the feedback @felixarntz!

The idea behind a simplified development environment was to simplify the effort required for new developers to contribute to the project. For example, running phpunit currently requires a development machine with a full WP setup and files in particular locations. Having a minimal development environment with the suggested defaults could significantly reduce the time it takes to start contributing to the project.

A separate repo sounds like a good solution!