-
Notifications
You must be signed in to change notification settings - Fork 383
Closed
Labels
ChangeloggedWhether the issue/PR has been added to release notes.Whether the issue/PR has been added to release notes.EnhancementNew feature or improvement of an existing oneNew feature or improvement of an existing one
Milestone
Description
Feature Description
As is well known, the universal analytics (UA) version of Google Analytics is being sunset imminently in favor of GA4. Support for GA4 in AMP just landed: ampproject/amphtml#24621 (comment)
The GA4 configuration uses the gtag vendor type as opposed to googleanalytics. Therefore:
- The entry label for "Google Analytics" should be updated to say "Google Analytics (Deprecated)" in:
amp-wp/includes/ecosystem-data/analytics-vendors.php
Lines 160 to 161 in 3007b13
| 'value' => 'googleanalytics', | |
| 'label' => 'Google Analytics', |
Note that the vendor entry on AMP.dev will be updated accordingly.
- There is a notice currently displayed when the user has selected
googleanalyticsto consider using Site Kit instead (which will support GA4 shortly per AMP: Add support for tagging with GA4 google/site-kit-wp#7221). However, the notice should be updated to be a warning here, perhaps by adding this sentence to the end of the paragraph:
Nevertheless, the
googleanalyticstype is obsolete as Google Analytics has switched to usegtagin the transition from Universal Analytics (UA) to GA4. Please usegtaginstead. Learn more about GA4 in AMP.
Acceptance Criteria
No response
Implementation Brief
No response
QA Testing Instructions
No response
Demo
No response
Changelog Entry
No response
Metadata
Metadata
Assignees
Labels
ChangeloggedWhether the issue/PR has been added to release notes.Whether the issue/PR has been added to release notes.EnhancementNew feature or improvement of an existing oneNew feature or improvement of an existing one
