Skip to content

Skip rendering child amp-img tags of amp-mega-menu  #7029

@milindmore22

Description

@milindmore22

Bug Description

A user reported a that he encounter a validation error when he tries to add amp-img under amp-mega-menu component. the validation error is regarding sizer being descendent of amp-mega-menu which is not allowed.

I am able to reprorudcue the issue at my end using the following HTML snippet

<amp-mega-menu height="30" layout="fixed-height">
  <nav>
    <ul>
      <li>
        <span role="button">Image</span>
        <div role="dialog">
          <amp-img
            src="https://amp-support.rt.gw/wp-content/uploads/2008/06/dsc09114-1-1024x768.jpg"
            width="300"
            height="200"></amp-img>
        </div>
      </li>
      <li>
        <span role="button">List</span>
        <div role="dialog">
          <ol>
            <li>item 1</li>
            <li>item 2</li>
            <li>item 3</li>
          </ol>
        </div>
      </li>
      <li>
        <a href="https://amp.dev/">Link</a>
      </li>
    </ul>
  </nav>
</amp-mega-menu>

Users Site: https://www.nmore.com/
My testing site. : https://amp-support.rt.gw/amp-mega-menu-with-image/?amp=1

Expected Behaviour

It should not produce validation error.

Screenshots

No response

PHP Version

7.4

Plugin Version

2.2.2

AMP plugin template mode

Transitional

WordPress Version

5.9.4

Site Health

No response

Gutenberg Version

No response

OS(s) Affected

No response

Browser(s) Affected

No response

Device(s) Affected

No response

Acceptance Criteria

No response

Implementation Brief

No response

QA Testing Instructions

No response

Demo

No response

Changelog Entry

No response

Metadata

Metadata

Assignees

Labels

BugSomething isn't workingChangeloggedWhether the issue/PR has been added to release notes.

Type

No type

Projects

Status

QA Passed

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions