-
Notifications
You must be signed in to change notification settings - Fork 383
Closed
Labels
ChangeloggedWhether the issue/PR has been added to release notes.Whether the issue/PR has been added to release notes.GroomedP1Medium priorityMedium priorityTech DebtDeprecations, inefficiencies, code healthDeprecations, inefficiencies, code healthWS:PerfWork stream for Metrics, Performance and OptimizerWork stream for Metrics, Performance and Optimizer
Milestone
Description
Feature description
The plugin package (AmpProject\AmpWP) is currently sitting at and enforcing level 3 of PHPStan static analysis.
There are 27 errors that need to be fixed so that we can raise the level to 4 and enforce this new quality level in Travis CI.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
- PHPStan does not show any detected errors when run on level 4.
Implementation brief
- Change the level to
4in the filephpstan.neon.dist. - Run
composer analyze. - Fix detected errors until no more are found.
QA testing instructions
Demo
Changelog entry
Metadata
Metadata
Assignees
Labels
ChangeloggedWhether the issue/PR has been added to release notes.Whether the issue/PR has been added to release notes.GroomedP1Medium priorityMedium priorityTech DebtDeprecations, inefficiencies, code healthDeprecations, inefficiencies, code healthWS:PerfWork stream for Metrics, Performance and OptimizerWork stream for Metrics, Performance and Optimizer