Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: TlsException to replace SocketException for TLS handshake errors #384

Merged
merged 3 commits into from
Mar 6, 2025

Conversation

luzrain
Copy link
Contributor

@luzrain luzrain commented Mar 5, 2025

This PR proposes a new TlsException to replace SocketException in cases where an exception occurs during the TLS handshake.

Related: #379

@luzrain luzrain changed the title Introduce TlsException to replace SocketException for TLS handshake errors Proposal: TlsException to replace SocketException for TLS handshake errors Mar 5, 2025
@luzrain luzrain force-pushed the tls_exception branch 7 times, most recently from 5e38ae8 to 7935cc5 Compare March 6, 2025 03:40
@kelunik
Copy link
Member

kelunik commented Mar 6, 2025

Thank you again!

@kelunik kelunik merged commit e2ee779 into amphp:5.x Mar 6, 2025
5 checks passed
@luzrain luzrain deleted the tls_exception branch March 6, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants