JIT isn't available in PHP <8.0#120
Merged
amnuts merged 1 commit intoamnuts:next-releasefrom Jul 27, 2025
Merged
Conversation
Owner
|
Hi @cpeel, My sincerest apologies for not having addressed this before now!! Many thanks for your contribution - I really do appreciate it! I'm going to be putting time aside next week in order to start addressing some issues and merging in pending PRs, so this will be merged in at that time. |
amnuts
approved these changes
Jul 18, 2025
amnuts
added a commit
that referenced
this pull request
Jul 28, 2025
amnuts
added a commit
that referenced
this pull request
Jul 28, 2025
* Add German language support (#123) * JIT isn't available in PHP <8.0 (#120) * Updated to latest js libraries * Updates for newer sass package * Fixes #122 * Fixes #118 * Tweaked readme --------- Co-authored-by: Matthias Straka <[email protected]> Co-authored-by: Casey Peel <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIT isn't available in PHP <8.0 and accessing the
jitkey in$statusresults in a Notice:The code handles this scenario, we just need to squash the lack of the key causing the notice.
Fixes #114