Skip to content

Commit e9c4775

Browse files
fix(web): mark pull request links as external (pingdotgg#8856)
1 parent 3958111 commit e9c4775

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

‎apps/web/src/components/pullRequest/PullRequestDetailPanel.tsx‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import {
1616
BookOpenIcon,
1717
CircleDotIcon,
1818
ChevronDownIcon,
19+
ExternalLinkIcon,
1920
FileDiffIcon,
2021
FolderGit2Icon,
2122
GitBranchIcon,
@@ -1161,12 +1162,13 @@ export function PullRequestDetailPanel({
11611162
onClick={() => void readLocalApi()?.shell.openExternal(detail.url)}
11621163
onContextMenu={(event) => openNumberContextMenu(event, detail)}
11631164
className={cn(
1164-
"shrink-0 font-medium underline-offset-2 hover:underline",
1165+
"inline-flex shrink-0 cursor-pointer items-center gap-0.5 font-medium underline-offset-2 hover:underline",
11651166
statePresentation.toneClassName,
11661167
)}
11671168
aria-label={`Open pull request #${detail.number} on host`}
11681169
>
11691170
#{detail.number}
1171+
<ExternalLinkIcon aria-hidden className="size-2.5" />
11701172
</button>
11711173
}
11721174
/>
@@ -1196,12 +1198,13 @@ export function PullRequestDetailPanel({
11961198
onClick={() => void readLocalApi()?.shell.openExternal(detail.url)}
11971199
onContextMenu={(event) => openNumberContextMenu(event, detail)}
11981200
className={cn(
1199-
"shrink-0 font-medium underline-offset-2 hover:underline",
1201+
"inline-flex shrink-0 cursor-pointer items-center gap-0.5 font-medium underline-offset-2 hover:underline",
12001202
statePresentation.toneClassName,
12011203
)}
12021204
aria-label={`Open pull request #${detail.number} on host`}
12031205
>
12041206
#{detail.number}
1207+
<ExternalLinkIcon aria-hidden className="size-2.5" />
12051208
</button>
12061209
}
12071210
/>

0 commit comments

Comments
 (0)