You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 67a1a31
Browse filesBrowse the repository at this point in the historyBrowse files
fix(stdio): remove specific listeners in close(), keep no-op error handlers
Address review feedback:
- Remove only the specific listeners attached in start() (data, error)
instead of removeAllListeners(), to avoid removing error handlers that
prevent uncaught exceptions from late EPIPE errors.
- Keep no-op error handlers on stdin/stdout/stderr after close() so that
late errors don't throw uncaught exceptions.
- The 'drain' listener that accumulates with back-pressure is on
_stderrStream (the pipe destination), not on processToClose.stderr.
unpipe() removes it from _stderrStream.
Refs: modelcontextprotocol#780, modelcontextprotocol#3070
0 commit comments