Skip to content

docs(memory): list all nine knowledge categories - #6864

Merged
kovtcharov-amd merged 2 commits into
amd:mainfrom
ityashag:docs/memory-category-count
Nov 6, 2026
Merged

kovtcharov-amd merged 2 commits into
amd:mainfrom
ityashag:docs/memory-category-count

Conversation

@ityashag

@ityashag ityashag commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Summary

Corrects the memory guide's category count from six to nine and adds the three missing categories: profile, system and permission.

Why

The Knowledge Categories section says there are six categories, but VALID_CATEGORIES in src/gaia/agents/base/memory_store.py has nine, and gaia memory status reports the others. The same guide already lists all nine in its Quick Start, so it contradicts itself.

I split the list because the missing three work differently: store() rejects them from a chat turn unless the caller passes allow_privileged=True.

Linked issue

Closes #3211

Changes

  • Says there are nine categories, and that six can be created in chat.
  • Adds a second table for profile, system and permission, and says where they come from, based on the comment above _PRIVILEGED_CATEGORIES.
  • The profile example follows the template in bootstrap.py, and the permission example comes from the comment on VALID_CATEGORIES.

Test plan

Evidence

N/A: this is a docs-only change. It doesn't touch the Agent UI, MCP tools, CLI behavior or the HTTP API.

  • Agent exposed in the Agent UI: N/A
  • MCP tools / servers: N/A
  • CLI: N/A
  • HTTP API / REST: N/A

Checklist

  • I have linked a GitHub issue above (Closes #N / Fixes #N / Refs #N).
  • I have described why this change is being made, not just what changed.
  • I have run linting and tests locally (python util/lint.py --all, pytest tests/unit/). Not run: this PR only changes one .mdx file and no code.
  • I have attached real-world evidence matched to the surface I changed (see Evidence above), or marked each surface N/A.
  • I have updated documentation if user-visible behavior changed (see CONTRIBUTING.md). This PR is the documentation change.

The guide said six, but VALID_CATEGORIES has nine. It now also explains that profile, system and permission can't be created from a chat turn.

Closes amd#3211
@github-actions github-actions Bot added the documentation Documentation changes label Nov 6, 2026
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Verdict: Approve

The memory guide said there were six knowledge categories; there are nine. This PR fixes the count and adds profile, system and permission in a separate table that says chat can't create them. All of it matches the code, and the section no longer contradicts the guide's own Quick Start and gaia memory status text.

Real-world evidence

N/A: docs-only change, with no runnable surface to exercise. The verdict rests on checking the docs against the memory store code.

🔍 Technical details

Issues found

🟢 One sentence slightly overstates what the dashboard can write (docs/guides/memory.mdx:300). The sentence names "reviewed changes in the memory dashboard" as a source for all three categories. In the code, the dashboard and the gaia memory review prompts can write only profile (USER_REVIEWED_CATEGORIES in memory_store.py:148). system is only collected, and nothing that goes through review can grant permission. Optional fix:

The other three can't be created from a chat turn. They come from onboarding, system context collection, and the `gaia memory` commands; the memory dashboard can also save reviewed `profile` entries:

Checked

  • The two tables together list exactly the nine names in VALID_CATEGORIES, and the split matches _PRIVILEGED_CATEGORIES.
  • No other page in docs/ still says "six categories".

Strengths

  • Splitting the table by who can write each category tells the reader why three of them never show up from chat. A bare count of nine wouldn't.
  • The examples come from the code: the profile one follows the onboarding template, and the permission one is quoted from the comment on VALID_CATEGORIES.

@kovtcharov-amd
kovtcharov-amd added this pull request to the merge queue Nov 6, 2026
Merged via the queue into amd:main with commit 5ac4409 Nov 6, 2026
14 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Documentation changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'one of six categories' contradicts the same doc and the categories actually written to the DB

2 participants