Repository navigation
docs(eval): use a fact id that exists in the scenario example - #6863
Merged
Merged
Conversation
The example named cfo_threshold, but the budget_2025 manifest entry calls it cfo_approval_threshold. Closes amd#3460
Contributor
|
Verdict: Approve The custom-scenario example in the eval guide now uses a fact id that really exists in the corpus, so readers who copy it get a valid scenario. I checked the manifest: Real-world evidenceN/A: this is a docs-only change with no runnable surface, so the verdict rests on static review alone. 🔍 Technical detailsIssues found: none. Strengths
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
fact_idin the custom scenario example, which names a fact that doesn't exist in the corpus manifest.Why
A reader who copies the Step 3 YAML gets a scenario pointing at a fact that isn't there, and nothing reports an error.
eval/corpus/manifest.jsonlistscfo_approval_thresholdforbudget_2025, notcfo_threshold.Linked issue
Closes #3460
Changes
cfo_thresholdtocfo_approval_thresholdin both turns of the example indocs/guides/eval-scenarios.mdx.Test plan
grep -n "cfo_threshold" docs/guides/eval-scenarios.mdx: no matches.eval/corpus/manifest.json:budget_2025hastotal_budget,engineering_budgetandcfo_approval_threshold.Evidence
N/A: this is a docs-only change. It doesn't touch the Agent UI, MCP tools, CLI behavior or the HTTP API.
Checklist
Closes #N/Fixes #N/Refs #N).python util/lint.py --all,pytest tests/unit/). Not run: this PR only changes one.mdxfile and no code.