Skip to content

Remove Legacy NSIS Windows Installer#192

Merged
kovtcharov merged 10 commits intoamd:mainfrom
kovtcharov:kalin/remove-exe
Jan 20, 2026
Merged

Remove Legacy NSIS Windows Installer#192
kovtcharov merged 10 commits intoamd:mainfrom
kovtcharov:kalin/remove-exe

Conversation

@kovtcharov
Copy link
Collaborator

@kovtcharov kovtcharov commented Jan 16, 2026

Summary

Removes the legacy NSIS-based Windows installer infrastructure in preparation for the new lightweight installer system described in the installer plan.

Changes

  • Deleted installer/ directory - NSIS scripts, batch files, and utilities
  • Removed workflows - build_installer.yml, test_installer.yml
  • Updated publish_installer.yml - Now focuses on Electron apps and points to pip/uv installation
  • Removed documentation - NSIS installer guide and specs
  • Updated references - CLAUDE.md, docs.json, packaging.mdx

Rationale

The NSIS installer was complex to maintain and inconsistent with how Python packages are typically distributed. The new installation approach will use:

  • One-liner scripts (irm https://amd-gaia.ai/install.ps1 | iex)
  • winget (winget install AMD.GAIA)
  • pip/uv (pip install amd-gaia)

Migration

Users should install GAIA via pip:

pip install amd-gaia
# or
uv pip install amd-gaia

@kovtcharov kovtcharov requested a review from itomek-amd January 16, 2026 01:07
@kovtcharov kovtcharov self-assigned this Jan 16, 2026
@github-actions github-actions bot added documentation Documentation changes installer Installer changes devops DevOps/infrastructure changes labels Jan 16, 2026
@kovtcharov-amd
Copy link
Collaborator

kovtcharov-amd commented Jan 20, 2026

@claude review this PR.

@github-actions
Copy link

github-actions bot commented Jan 20, 2026 •
edited
Loading

Claude finished @kovtcharov-amd's task —— View job

PR Review Complete

Overall Assessment: 🟢 Approve - Clean removal of legacy installer infrastructure with minor issues to address in follow-up.

Summary

This PR successfully removes the NSIS Windows installer system (~3,182 lines deleted) in preparation for the new lightweight installer approach. The changes are well-structured and the rationale is sound.

What's Good

  • Clean deletion of all NSIS-related files (installer/, workflows, docs, agent definition)
  • Updated publish_installer.yml now focuses on Electron apps with pip/uv installation instructions
  • Documentation updates in docs/docs.json and docs/sdk/packaging.mdx reference the new installer plan
  • Lint script improvements in util/lint.py and util/lint.ps1 - simplified and cleaned up

🟡 Issues Found (Non-blocking, should be addressed in follow-up)

  1. README.md:3 - Still references deleted workflow:

    [![](https://github.com/amd/gaia/actions/workflows/build_installer.yml/badge.svg)]

    This badge will break after merge.

  2. .github/workflows/local_hybrid_tests.yml - Still depends on deleted build_installer.yml:

    jobs:
  build-installer:
    uses: ./.github/workflows/build_installer.yml

    This workflow will fail after merge.

  3. .claude/agents/github-actions-specialist.md:45-48 - Documents deleted workflows:

    | Build Installer | `build_installer.yml` | NSIS Windows installer |
| Test Installer | `test_installer.yml` | Installer validation |

Recommendation

These are minor cleanup items that can be addressed in a follow-up PR. The core installer removal is correct and complete.

@github-actions github-actions bot added the tests Test changes label Jan 20, 2026
@kovtcharov
Copy link
Collaborator Author

kovtcharov commented Jan 20, 2026

@claude review the changes once more.

@github-actions
Copy link

github-actions bot commented Jan 20, 2026 •
edited
Loading

Claude finished @kovtcharov's task —— View job

PR Review Complete

  • Read pr-diff.txt to analyze current state
  • Read pr-files.txt for changed file list
  • Verify issues from previous review are addressed
  • Provide updated review assessment

Overall Assessment: 🟢 Approve - All previous issues have been resolved.

Previous Issues - All Fixed

Issue Status
README.md broken badge to build_installer.yml ✅ Fixed - Now references test_gaia_cli.yml
local_hybrid_tests.yml dependency on deleted workflow ✅ Fixed - Workflow deleted
github-actions-specialist.md documenting deleted workflows ✅ Fixed - References removed

Summary

Clean removal of legacy NSIS installer infrastructure (~3,600 lines deleted). The PR now:

  • Deletes all installer-related files (installer/, workflows, docs, agent)
  • Updates publish_installer.yml to focus on Electron apps
  • Adds test_gaia_cli_linux.yml and test_gaia_cli_windows.yml improvements
  • Properly cleans up all references to deleted content

Ready to merge.

@kovtcharov kovtcharov enabled auto-merge January 20, 2026 08:38
@kovtcharov kovtcharov added this pull request to the merge queue Jan 20, 2026
Merged via the queue into amd:main with commit 0f32bf3 Jan 20, 2026
53 checks passed
@kovtcharov kovtcharov deleted the kalin/remove-exe branch January 20, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itomek itomek itomek approved these changes

@kovtcharov-amd kovtcharov-amd kovtcharov-amd approved these changes

@itomek-amd itomek-amd Awaiting requested review from itomek-amd

Assignees

@kovtcharov kovtcharov

Labels

devops DevOps/infrastructure changes documentation Documentation changes installer Installer changes tests Test changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kovtcharov @kovtcharov-amd @itomek