Add Electron CI tests for Dependabot PR validation#183
Merged
kovtcharov-amd merged 12 commits intoamd:mainfrom Jan 16, 2026
Merged
Add Electron CI tests for Dependabot PR validation#183kovtcharov-amd merged 12 commits intoamd:mainfrom
kovtcharov-amd merged 12 commits intoamd:mainfrom
Conversation
- Add EMR Dashboard to Dependabot config and test matrix - Add EMR Dashboard integration tests (test_emr_dashboard.js) - Add headless E2E runtime tests that launch Electron apps - Make build failures blocking (remove continue-on-error) - Add version consistency and structure validation - Remove deprecated spectron dependency When Dependabot updates Electron versions, these tests will catch: - Missing or broken entry points - Invalid package.json configurations - Electron API breaking changes (via runtime launch tests) - Version inconsistencies between apps and framework
- Add test_framework_integration.js with 32 tests covering: - Framework core validation (main.js, app-controller, services) - App structure compliance (example and jira apps) - Throwaway app creation test (validates framework contract) - Version compatibility matrix across all apps - Security configuration validation (nodeIntegration, contextIsolation) - Update workflow to run framework integration tests The throwaway app test is the key TDD test: - Creates a minimal app using the same pattern as documented apps - Uses the same Electron version that Dependabot would update - Verifies the framework contract is not broken by updates Total: 84 tests across 5 test files
Renamed for clarity: - test_jira_app.js -> test_electron_jira_app.js - test_example_app.js -> test_electron_example_app.js - test_emr_dashboard.js -> test_electron_emr_dashboard.js - test_functional.js -> test_electron_functional.js - test_framework_integration.js -> test_electron_framework_integration.js Updated workflow references to match new filenames.
Dependabot config changes: - Enable PRs for Example app (was monitor-only, now limit: 1) - Enable PRs for Jira app (was monitor-only, now limit: 1) - All Electron apps now on weekly schedule (Monday) - Added 'electron' label to all Electron app configs Test changes: - Throwaway app test now uses FRAMEWORK electron version (src/gaia/electron/package.json) as the canonical source - This ensures the test validates against what Dependabot updates Now Dependabot will update: - Root package.json (npm workspaces master) - src/gaia/electron (framework) - src/gaia/apps/example/webui - src/gaia/apps/jira/webui - src/gaia/agents/emr/dashboard/electron
Review feedback addressed: 1. Unused imports (test_electron_framework_integration.js) - Removed unused `execSync` and `spawn` from imports 2. Hardcoded version requirements - Extracted MIN_ELECTRON_VERSION (31) and MIN_FORGE_VERSION (7) as constants - Added detailed documentation explaining why these versions are required - Constants are now in one place for easy maintenance 3. Hardcoded 5-second timeout - Made configurable via ELECTRON_LAUNCH_TIMEOUT_MS environment variable - Added documentation explaining why 5 seconds is the default - Apps with heavy initialization can override if needed 4. Platform-specific packaging - Added comments clarifying this runs on Linux (ubuntu-latest) - Windows/macOS packaging is tested in separate workflow - Added DEBUG output for electron-forge troubleshooting
The apps (jira, example) are part of npm workspaces defined in root package.json. Running 'npm ci' in the subdirectory doesn't work because workspaces hoist dependencies to the root node_modules. Fix: Install from root directory which properly installs all workspace dependencies including electron.
electron-forge uses the local package-lock.json to determine project root and expects electron to be installed there. With npm workspaces, dependencies are hoisted to root but forge still looks locally. Fix: Run npm install in app directory after root npm ci to ensure electron is available where forge expects it.
Use npm ci --prefix . from the app directory instead of installing from root with workspaces. This matches the pattern in build-electron-apps.yml and ensures electron is installed locally where electron-forge expects it.
kovtcharov-amd
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add robust CI workflow to validate Electron apps when Dependabot submits PRs.