1227 fix layout equals false #1307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crimson-knight
pushed a commit
that referenced
this pull request
Nov 21, 2022
* fix: remove webpack from dependencies This change removes webpack from the dependencies. It also upgrades bootstrap to 5.0 using cdn links. * fix: linting issue * fix: specs * fix: rollback default database * fix: specs * refactor: minor adjustments * refactor: cleanup more tests * fix: base64 spec * refactor: avoid around_each for all specs * fix: broken wrapper * fix: fix REDIS_URL * fix: make github action match docker compose * fix: remove old crystal version file * fix: update missing template changes * fix: forcefully add public assets * fix: remove cli from .gitignore * fix: use latest images * fix: remove nodejs from Dockerfile * fix: remove node dependency * fix: restore filter * fix: missed in slang template * fix: needs to be type module for ES6 support * Remove garnet spec (#1306) * fix: remove garnet_spec shard as dependency * fix: specs * 1227 fix layout equals false (#1307) * fix: check for false * fix: #1227 support LAYOUT=false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR fixes issue #1227 . This adds a check to see if LAYOUT is false or "false" and disables the layout for all of the render calls in the controller.
Alternate Designs
Passing
layout=falseto all render calls in the controllerBenefits
Reduces the code needed to disable the layout.
Possible Drawbacks
It's not clear that LAYOUT can be set to false. Its a bit awkward to have a (String | Boolean) union type for this field.