Explicitly declare the UTF-8 charset for json responses #1231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliasjpr
previously approved these changes
Sep 10, 2020
Contributor
|
@damianham after reading https://www.w3.org/International/questions/qa-choosing-encodings and this https://www.w3.org/International/questions/qa-choosing-encodings#http I think it is best to have all responses to default to UTF-8. I wonder if there would be any implications for currently running Amber Apps. Thoughts |
eliasjpr
dismissed
their stale review
Failing tests. Please correct and I will be happy to review again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
I was getting incorrect decoding of UTF-8 characters in a Flutter application pulling data from an Amber web application that contained text strings with accented characters and this Dart issue explains why dart-lang/http#175
Alternate Designs
Benefits
Dart HTTP clients will be able to correctly decode json data from an Amber app
Possible Drawbacks
None - it conforms to the json spec