Add CLI driver tests and build workflow#22
Merged
zslayton merged 15 commits intoamazon-ion:masterfrom Mar 7, 2022
camerondurham:dev/cli-driver-tests
Merged
Add CLI driver tests and build workflow#22zslayton merged 15 commits intoamazon-ion:masterfrom camerondurham:dev/cli-driver-tests
zslayton merged 15 commits intoamazon-ion:masterfrom
camerondurham:dev/cli-driver-tests
Conversation
* Added Dockerfile to build minimal, multi-stage image * Updated README with build instructions Recording of local build/test: https://asciinema.org/a/Ql7Xc5fgxxvkFrjjcuMbR0npY Currently builds image size 85.8MB from local build on macOS ``` docker images REPOSITORY TAG IMAGE ID CREATED SIZE ion-cli 0.1.1 e81a9d863b95 49 minutes ago 85.8MB ```
Update ion-rs version, ion-c submodule and Dockerfile
Closed
zslayton
approved these changes
Mar 7, 2022
Contributor
zslayton
left a comment
zslayton
left a comment
There was a problem hiding this comment.
Looks good, thanks for cleaning it up!
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Implement #10, adding CLI driver tests.
Description of changes:
This CR adds basic tests for the CLI driver, using linked pull request (partiql/partiql-lang-rust#45) as example.
Will add any
rustfmtchanges in another CR and enable rustfmt checks when completed. This is a simplified CR only adding tests, breaking apart #20 into smaller pieces. Unfortunately was not able to successfully squash old commits but diff shows the only files changed.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.