Conversation
| pub mod dump; | ||
|
|
||
| // Creates a Vec of CLI configurations for all of the available built-in commands | ||
| pub fn built_in_commands() -> Vec<App<'static, 'static>> { |
There was a problem hiding this comment.
The project's directory structure and the contents of this file were inspired by cargo, which follows a similar pattern.
There was a problem hiding this comment.
Are you/cargo making some distinction between "built-in" commands and some other type of commands? If not, perhaps the term is simply "subcommands" (here and elsewhere).
There was a problem hiding this comment.
Are you/cargo making some distinction between "built-in" commands and some other type of commands?
Yes. "Built-in" commands are part of the same ion executable (and so show up in the output of ion help) while "external" commands are (potentially 3rd party) executables installed separately on the user's $PATH. See #1 for some extra detail.
pbcornell
left a comment
pbcornell
left a comment
There was a problem hiding this comment.
One question below, otherwise looks like a good starting place, and assuming we're comfortable changing the contract as discussions continue (I assume that's what you mean by "API subject to change" in the readme).
| pub mod dump; | ||
|
|
||
| // Creates a Vec of CLI configurations for all of the available built-in commands | ||
| pub fn built_in_commands() -> Vec<App<'static, 'static>> { |
There was a problem hiding this comment.
Are you/cargo making some distinction between "built-in" commands and some other type of commands? If not, perhaps the term is simply "subcommands" (here and elsewhere).
2 participants
Description of changes:
cargo buildorcargo installwill build the code in theion-csubmodule and link against the resulting libraries.ion dumpcommand that wraps theion-cCLI and exposes a limited number of options.README.mdfile.Testing
If you don't already have it, you can install
cargousingrustup.Example output for
ion:Example output for
ion help dump:By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.