Repository navigation
fix: Keep $ patterns in route param values literally - #2406
Merged
Merged
Conversation
Route param values containing `$` replacement patterns (e.g. `$&`, $', $`, $1) were interpreted by `String.replace`, corrupting localized URLs produced by the navigation APIs (`getPathname`, `Link`, `redirect`, `useRouter`) and by middleware localized-pathname redirects. In the worst case (`$&`) the placeholder was re-inserted and `compileLocalizedPathname` threw 'Insufficient params provided'. Pass a replacer function so param values are always inserted verbatim.
|
@soroush5 is attempting to deploy a commit to the next-intl Team on Vercel. A member of the Team first needs to authorize it. |
1 task done
The replacer function added in this PR grows the brotlied bundle by 4 B, from 3155 B to 3159 B. Co-Authored-By: Claude Opus 5 <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2405.
Route param values containing
$replacement patterns ($&,$',$`,$1) were interpreted byString.replace, corrupting localized URLs from the navigation APIs (getPathname,Link,redirect,useRouter) and from middleware localized-pathname redirects. With$&the placeholder was re-inserted andcompileLocalizedPathnameeven threwInsufficient params provided.Both substitution sites now pass a replacer function so values are inserted verbatim. Regression tests added in
navigation/shared/utils.test.tsxandmiddleware/utils.test.tsx.Verification: full
next-intlsuite 899/899 green,tsc --noEmit, ESLint and Prettier clean.