Skip to content

Keep settings navigation visible while scrolling#142

Merged
amalshaji merged 1 commit into
mainfrom
codex/sticky-settings-header
Jul 20, 2026
Merged

Keep settings navigation visible while scrolling#142
amalshaji merged 1 commit into
mainfrom
codex/sticky-settings-header

Conversation

@amalshaji

Copy link
Copy Markdown
Owner

Summary

  • constrain the settings page shell to the application viewport
  • keep the navigation bar and Back button sticky while the preferences body scrolls independently
  • add regression coverage for the viewport, sticky-header, and scroll-container layout contract

Root cause

The settings shell used min-h-screen, which allowed the page to grow with its form content. That handed scrolling to the document instead of the existing main content region, so the navigation bar scrolled out of view.

Impact

The settings navigation remains accessible at the top of the window while users scroll through longer preferences.

Testing

  • bun test — 55 tests pass
  • bun run build
  • bunx biome check src/pages/Settings.tsx src/pages/Settings.test.ts
  • Chrome runtime verification at 1024×768 confirmed window.scrollY remains 0, the header remains at top: 0, and the main pane scrolls independently

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
dbcooper 7681f74 Commit Preview URL

Branch Preview URL
Jul 20 2026, 12:00 PM

@amalshaji
amalshaji marked this pull request as ready for review July 20, 2026 12:02
@amalshaji
amalshaji merged commit bbe1993 into main Jul 20, 2026
4 checks passed
@amalshaji
amalshaji deleted the codex/sticky-settings-header branch July 20, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant