Repository navigation
fix(companion): ignore a trailing busy for a finished background job - #1472
Merged
Merged
Conversation
A child session can report busy after its background job already completed, with no idle event to follow. The companion then kept the specialist on screen indefinitely. Pass whether the job board has settled the session's job and skip the busy registration in that case. Fixes alvinunreal#1470
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1470.
A child session can report
busyafter its background job already finished, with noidleevent after it. The companion then kept the specialist on screen indefinitely.onSessionStatusnow takes ajobFinishedflag, set from the background job board, and skips registering busy in that case. Added a test that fails on the unfixed source and passes with the change (61 passed, 0 failed in the companion tests).