test: parallel tests can error on already deleted dataset

alvarowolfx · alvarowolfx · commit 5f9aa309cbb1 · 2023-06-01T14:53:32.000-04:00
diff --git a/samples/test/datasets.test.js b/samples/test/datasets.test.js
@@ -174,16 +174,16 @@ describe('Datasets', () => {
     );
 
     for (const dataset of datasets) {
-      const [metadata] = await dataset.getMetadata();
-      const creationTime = Number(metadata.creationTime);
+      try {
+        const [metadata] = await dataset.getMetadata();
+        const creationTime = Number(metadata.creationTime);
 
-      if (isResourceStale(creationTime)) {
-        try {
+        if (isResourceStale(creationTime)) {
           await dataset.delete({force: true});
-        } catch (e) {
-          console.log(`dataset(${dataset.id}).delete() failed`);
-          console.log(e);
         }
+      } catch (e) {
+        console.log(`dataset(${dataset.id}).delete() failed`);
+        console.log(e);
       }
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -174,16 +174,16 @@ describe('Datasets', () => {`
`174`	`174`	`);`
`175`	`175`
`176`	`176`	`for (const dataset of datasets) {`
`177`		`- const [metadata] = await dataset.getMetadata();`
`178`		`- const creationTime = Number(metadata.creationTime);`
	`177`	`+ try {`
	`178`	`+ const [metadata] = await dataset.getMetadata();`
	`179`	`+ const creationTime = Number(metadata.creationTime);`
`179`	`180`
`180`		`- if (isResourceStale(creationTime)) {`
`181`		`- try {`
	`181`	`+ if (isResourceStale(creationTime)) {`
`182`	`182`	`await dataset.delete({force: true});`
`183`		`- } catch (e) {`
`184`		- console.log(`dataset(${dataset.id}).delete() failed`);
`185`		`- console.log(e);`
`186`	`183`	`}`
	`184`	`+ } catch (e) {`
	`185`	+ console.log(`dataset(${dataset.id}).delete() failed`);
	`186`	`+ console.log(e);`
`187`	`187`	`}`
`188`	`188`	`}`
`189`	`189`	`}`