DEVOPS-425 | Docker spark version consistency #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markhamstra
reviewed
Jul 9, 2018
Jenkinsfile
Outdated
There was a problem hiding this comment.
Ummm... you're reconstructing spark_version -- just use it directly. For release builds, the SNAPSHOT will never be part of pom.version, so you could even use that instead of making spark_version. The only question with that is whether we'll want SNAPSHOT in the docker tag for PR builds (which don't use the docker image now, but may at some point.)
Author
There was a problem hiding this comment.
Ah great point. I would like it to be labeled as -SNAPSHOT for PR builds
jayceeb
force-pushed
the
align-docker-version
branch
from
7079061 to
bec3e6b
Compare
yeweizhang
approved these changes
Jul 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make our docker spark version consistent with how we name our jar files.
I will also push the same changes to our other branches once we finalize on this route