Added 'Open External' keyboard shortcut#497
Conversation
RvanderLaan
left a comment
RvanderLaan
left a comment
There was a problem hiding this comment.
PRs are most certainly welcome, thanks for taking the time! We should indeed add docs about contributing
You could also replace the function on the "Open External" menu item (frontend/containers/ContentView/menu-items.tsx) to use your function, so the hotkey and menu item behave the same, that would be more natural too
Besides that and one other possible tweak, it's looking good - nice work! 👍
|
Instead of limiting to a certain threshold, I think it is better to let the user decide. So I added a little warning dialog when there are at least 10 files selected before doing the
However, if you think it is still too dangerous, I can force the opening to stop after the 25th file (I should then add this info to the warning text of the dialog).
I thought of moving the I also wanted to give another class to the div with the filenames instead of Finally, It's out of the scope of this pr but my last commit fixes a bug i've encountered while trying to delete files. Basicly, I couldn't exit the removal dialog box saying "Are you sure you want to delete" after pressing |
RvanderLaan
left a comment
RvanderLaan
left a comment
There was a problem hiding this comment.
That's even better, I was thinking this approach that after I posted that last suggestion 👏
Just left some suggestions for the textual content, the implementation looks good!
That SubLocationExclusion component indeed doesn't belong there with the current naming. They're all basically just confirmation modals, it needs some more thorough refactoring. That also goes for deletion-confirmation-list. Better to leave that for later, thanks for pointing it out 👍
I'll take a look at that Esc listener issue this weekend, we've had some issues with some events being listened globally for various reasons..
2 participants
Hello,
Following this issue I recently opened (#495), I added the keyboard shortcut "Open external" to the list of already existing shortcuts.
I set the default key combination to "Ctrl + Enter", I also thought of setting "Ctrl + Space" but after trying it, I found the former more natural.
Also, compared to the default "Right Click -> Open External" on a single entry, this shortcut opens all selected files.
As I did not find a contribution section, neither in the readme nor in the wiki, I do not know if you accept such pr. If not, I'm sorry for the inconvenience.