WIP: Multi split outliner#429
Merged
Merged
Conversation
Collaborator
|
@RvanderLaan I can't see the difference in the preview 🙈 I will still take a look and use VSCode as reference. |
Collaborator
Author
|
yeah I didn't demonstrate it very well 😅 But it is far from where it needs to be. I feel like I overcomplicated it, but even after retrying two times I can't figure out a simpler approach I'm gonna give it one last shot today |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can't get the behavior quite right yet..
Preview:
Preview gif
Edit: I couldn't get it working in this approach. The collapse/expand logic got way too complicated in addition to the resizing.
I've swapped it out for a CSS-only approach now, no more manual layout calculations:
allusion-multi-split-css-only.mp4
I think it works good enough for now. Possible TODOs