Skip to content

RC6 fixes#387

Merged
RvanderLaan merged 12 commits into
masterfrom
rc6-fixes
Dec 5, 2021
Merged

RC6 fixes#387
RvanderLaan merged 12 commits into
masterfrom
rc6-fixes

Conversation

@RvanderLaan

@RvanderLaan RvanderLaan commented Dec 4, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • Overflow issues in tag editor overlay and the one in the inspector rc6 new UI cannot fully see all tags in detailed view #382
  • Prevent backspace in tag editor overlay input field from navigating back to the main view when having an image open Backspace doing two things at a time #385
  • Browser extension issue: imported images being immediately shown The images saved by the browser plug-in cannot be viewed directly in allusion. #386
  • The tag editor overlay should show tags for the current image after navigating left/right with a single image open
  • Magnifying glass icons in outliner shift to the right for tags with long names
  • Fix for weird behavior when clicking tag rename input rc6 TagsTreeItem renaming will trigger onBlur event on second mouse click #388
  • Fix for deleting files: Didn't work anymore since upgrading to a newer Electron version (internal breaking changes)
  • Bonus: Task bar entry will show a progress bar when downloading an update
  • Tweaked behavior for left/right arrow keys in gallery when the TagEditor overlay is open. I tried to find a solution that keeps the best of both worlds:
    • It now no longer closes when moving between images, nor is the cursor in the input field moved
    • To still have control over input field text, holding Shift will move the text cursor, but the event no longer selects files in the gallery

@RvanderLaan RvanderLaan requested a review from hummingly December 4, 2021 17:22
@RvanderLaan RvanderLaan mentioned this pull request Dec 5, 2021
Closed
@RvanderLaan
Fix for weird behavior when clicking tag rename input #388
5f43765
@RvanderLaan
Fix for deleting files (changed behavior in new Electron version)
1bf03a9
@RvanderLaan
Fix for issue in file detection after initialization #386
3233ab0
@RvanderLaan
More layout fixes: Long tag names in outliner pushed button search ou…
d2cdf3e 
…t of view

I am the flex king now
@RvanderLaan
Select current image in SlideMode so the TagPopover shows its tags in…
999e1fa 
…stead of those from the last selected images
@RvanderLaan
Changed default viewSlide hotkey to Enter instead of alt+0
c8b2962
@RvanderLaan
Keep TagEditor overlay open when moving between image in main gallery:
41e2f7d 
Made it so that holding shift applies arrow key events to TagEditor input, otherwise the events propagate up and do not effect itself
That's the best I could come up with to have the best of both worlds
@RvanderLaan RvanderLaan changed the title WIP: RC6 fixes RC6 fixes Dec 5, 2021
@hummingly

hummingly commented Dec 5, 2021

Copy link
Copy Markdown
Collaborator

The changes are mostly CSS related, so I don't really have anything to say. We should add visual tests in the future to make sure layouts do no break this easily. Playwright is a pretty nice option but I think we would need to fiddle around with webpack.

@RvanderLaan RvanderLaan merged commit f6f08fa into master Dec 5, 2021
@RvanderLaan RvanderLaan deleted the rc6-fixes branch December 5, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hummingly hummingly hummingly approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RvanderLaan @hummingly