Repository navigation
test: skip flaky "loop includes MCP instructions" test, tracked in #181 - #186
Merged
Merged
Conversation
This test intermittently fails in CI (and reproduces locally in isolation, ruling out cross-file leakage) with `InterruptError: All fibers interrupted without error`, most likely from this test's own .instance scope teardown racing against the still-hanging llm.hang() (Stream.never-backed) fiber's interruption. Confirmed the explicit Fiber.interrupt(fiber) call in the test body isn't the source (wrapping it in Effect.ignore didn't fix it). Skipping rather than deleting so the coverage gap is visible and the test is ready to re-enable once someone with more Effect-runtime/Scope context traces the actual finalizer responsible. Full investigation in #181. Co-Authored-By: Claude Sonnet 5 <[email protected]>
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Relates to #181 (documents the investigation — not closing it, since the root cause is still unresolved, just quarantined)
Type of change
What does this PR do?
`packages/opencode/test/session/prompt.test.ts`'s "loop includes MCP instructions in model system context" test has been intermittently failing CI across several unrelated PRs today (#180, #182, #183, #184 — all pure-CSS/a11y changes, not touching this code path) with:
```
InterruptError: All fibers interrupted without error