Repository navigation
fix(ui): stop hardcoding WSL warning icon color, use icon-muted token - #184
Merged
Merged
Conversation
The "WSL not installed" dialog's warning triangle SVG hardcoded fill="#DBDBDB" (equal to --v2-grey-400 by coincidence) instead of a semantic token, so it never adapted to the dark theme. Switched to fill="currentColor" and set color: var(--v2-icon-icon-muted) on the wrapper class, matching how every other icon in this design system is themed. Part of the dark-mode/Apple-like design pass (opencode#171). Co-Authored-By: Claude Sonnet 5 <[email protected]>
6 tasks
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
1 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Relates to #171 (the icon-only clear-search button in `components/settings-v2/servers.tsx`, also in this issue's scope, was already fixed in #182 — not closing #171 here since dialog-server-v2.tsx / dialog-server-qr-code.tsx / providers.tsx / ssh-tunnel + tailscale add-server dialogs were also audited clean and don't need this PR to close it)
Type of change
What does this PR do?
Audited `components/settings-v2/servers.tsx`, `providers.tsx`, `dialog-server-v2.tsx`, `dialog-server-qr-code.tsx`, and the SSH-tunnel/Tailscale/WSL "add server" dialogs for raw hex colors, ad-hoc shadows, non-token Tailwind classes, and missing `aria-label`s.
Found one real gap: the "WSL not installed" dialog's warning-triangle SVG (`wsl/dialog-add-server.tsx`) hardcoded `fill="#DBDBDB"` — which happens to equal `--v2-grey-400`, but as a literal hex it never adapts to the dark theme like every other icon in this design system does. Switched the SVG to `fill="currentColor"` and set `color: var(--v2-icon-icon-muted)` on its wrapper class (`wsl/dialog-add-wsl-server.css`).
Everything else audited clean.
How did you verify your code works?
Screenshots / recordings
Not captured — this environment can only run the app inside its Electron shell, not a plain browser preview (confirmed in earlier work this session). The change is a one-line color-source swap with an equivalent computed color in light mode, so I'm confident in the fix, but a visual double-check by a maintainer in both themes would be good before merge.
Checklist