Repository navigation
fix(a11y): add missing aria-label to legacy shortcuts clear-search button - #183
Merged
Merged
Conversation
…tton Same icon-only "clear search" gap already fixed for the v2 shortcuts view (see PR #182) also existed in the legacy (non-v2) SettingsKeybinds component's own clear button — missed in that sweep since it matched a different <IconButton> (not <IconButtonV2>) call site. Part of the dark-mode/Apple-like design pass (opencode#170). Co-Authored-By: Claude Sonnet 5 <[email protected]>
6 tasks
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
1 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Relates to #170 (broader scope than this one fix — not closing it)
Type of change
What does this PR do?
Follow-up to #182: the icon-only "clear search" gap already fixed there for the v2 shortcuts view (`SettingsKeybindsV2View`) also exists in the legacy (non-v2) `SettingsKeybinds` component's own clear button — missed in that sweep because it's a separate `` call site (not ``) further down the same file. Adds the same `common.clearSearch` label.
Rest of `components/settings-v2/general.tsx` and `components/settings-keybinds.tsx` audited clean: no raw hex, no ad-hoc box-shadow, no non-token Tailwind classes.
How did you verify your code works?
Screenshots / recordings
Not applicable — no visual change, only an added `aria-label` attribute.
Checklist