docs: correct etherscan url examples in Chain spec#300
Merged
Conversation
The examples for etherscan_api_url/etherscan_base_url had trailing slashes, contradicting the ensure_no_trailing_etherscan_url_separator invariant, and the api example used the pre-V2 form. Regenerate chains.schema.json, which embeds these doc comments as descriptions.
sueun-dev
requested review from
DaniPopes,
grandizzy,
klkvr,
mattsse and
onbjerg
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
etherscan_api_urlandetherscan_base_urlonChainhad trailing slashes, which contradicts theensure_no_trailing_etherscan_url_separatortest invariant that asserts no etherscan url ends with/.https://api.etherscan.io/v2/api?chainid=1andhttps://etherscan.io.assets/chains.schema.json, which embeds these doc comments as field descriptions.Tests
cargo test --no-default-features --features std,schema,serde(schema_up_to_date, spec_up_to_date, ensure_no_trailing_etherscan_url_separator pass)cargo +nightly fmt --all --checkcargo clippy --workspace --all-features