Merged
Conversation
mattsse
requested review from
DaniPopes,
Evalir,
gakonst,
onbjerg and
prestwich
as code owners
DaniPopes
reviewed
Apr 23, 2024
crates/provider/src/heart.rs
Outdated
|
|
||
| // FIXME: this is a hotfix to prevent a race condition where the heartbeat would miss the | ||
| // block the tx was mined in | ||
| let mut interval = tokio::time::interval(Duration::from_secs(7)); |
Member
There was a problem hiding this comment.
Get polling interval from provider?
DaniPopes
approved these changes
Apr 23, 2024
onbjerg
approved these changes
Apr 24, 2024
2 tasks
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
* fix: better tx receipt mitigation * rustfmt * use client poll interval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we still encounter issues with low block times (arbitrum) resulting in hanging requests.
this provides a slightly better mitigation that keeps polling for the receipt based on an interval while also awaiting the pending res from the heartbeat
foundry-rs/foundry#7642