fix: actually retry failed block fetches instead of skipping them#3698
Merged
mattsse merged 1 commit intoalloy-rs:mainfrom Feb 17, 2026
Merged
fix: actually retry failed block fetches instead of skipping them#3698mattsse merged 1 commit intoalloy-rs:mainfrom
mattsse merged 1 commit intoalloy-rs:mainfrom
Conversation
vanityKoa
requested review from
DaniPopes,
klkvr,
mattsse,
onbjerg and
zerosnacks
as code owners
mattsse
approved these changes
Feb 17, 2026
Member
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
LGTM — the bug analysis is correct: continue in the for loop advances to the next block number instead of retrying the current one, so failed fetches were silently skipped. The inner loop fix with per-block retries is clean and correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The retry logic in
NewBlocks::into_block_streamwas broken:continuein aforloop advances the iterator, so failed blocks were skipped rather than retried. The sharedretriescounter also meant retry budget was spread across the whole batch instead of per-block.Moved retries into an inner loop so each block gets its own retry attempts.