Merged
Conversation
- Remove jsonrpsee and jsonrpsee-types workspace deps - Remove FilterId <-> jsonrpsee SubscriptionId conversions (rpc-types-eth) - Remove ForkchoiceUpdateError -> jsonrpsee ErrorObject conversion (rpc-types-engine) - Remove jsonrpsee-types feature from rpc-types, rpc-types-eth, rpc-types-engine - Remove rpc-types-json feature from alloy meta-crate - Rewrite test_subscription_race_condition to use tokio-tungstenite mock server - Rewrite serde_json_header test to use local deserialization structs Amp-Thread-ID: https://ampcode.com/threads/T-019c5c46-90c3-7619-9be3-555766617985 Co-authored-by: Amp <[email protected]>
gakonst
requested review from
DaniPopes,
grandizzy,
klkvr,
mattsse,
onbjerg and
zerosnacks
as code owners
mattsse
approved these changes
Feb 14, 2026
gakonst
force-pushed
the
mattsse/remove-jsonrpsee-deps
branch
from
94f0efe to
0a0eecc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove all
jsonrpseeandjsonrpsee-typesdependencies from the workspace.Changes
jsonrpseeandjsonrpsee-typesfrom workspace depsFilterId <-> jsonrpsee_types::SubscriptionIdconversions inrpc-types-ethForkchoiceUpdateError -> jsonrpsee_types::ErrorObjectconversion inrpc-types-enginejsonrpsee-typesfeature fromrpc-types,rpc-types-eth,rpc-types-enginerpc-types-jsonfeature fromalloymeta-cratetest_subscription_race_conditionto use atokio-tungstenitemock WS server instead ofjsonrpsee::serverserde_json_headertest with local structs instead ofjsonrpsee_types::SubscriptionResponseTesting
cargo check --workspace --all-featurespasses.cargo tree -i jsonrpseeconfirms zero references.Prompted by: matthias